Reduce image adjustment triggers #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggling channels has set up the image adjustment panel for the selected channel by getting a currently displayed image and using its values to populate the panel's controls. Changing each of these controls in turn triggered additional image updates, though typically without changing the image since it already had these settings. To reduce these triggers: - Add another flag to ignore general image adjust updates, toggled when setting image adjust channels - Auto-intensity range updates only get values when ignoring image updates - Refactor getting the currently selected viewers and a displayed image into separate functions
Ignore callback when turning off the auto value.
The `RangeEditor` slider controls may shift unexpectedly, such as suddenly decreasing to 0 when shifting only slightly downward, or shifting upward before shifting downward. Clicking on a new position may also bring the slider there, but releasing the mouse button will cause the slider to pop back to its original positions. A shift in one intensity control can cause a further unexpected shift in the other control since we attempt to synchronize them. For example, the max intensity slider cannot be below the min slider, so an unintentional shift in the max slider to 0 will also cause the min slider to shift to 0. As a workaround, turn off this synchronization during intensity slider shifts. Leave it on when changing the auto setting to allow it to respond to directly toggling the auto control, and toggling it by moving a slider appears to respond to the initial shift rather than an unexpected subsequent shift.
yoda-vid
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggling channels in the "Adjust Image" panel has retrieved a currently displayed image and using its values to populate the panel's controls. Changing each of these controls in turn triggered additional image updates, though typically without changing the image since it already had these settings. Toggling the auto-intensity has similarly triggered an "update" to the current value. While this design has simplified the callbacks, it also leads to many unnecessary triggers. This PR reduces many of those triggers by ignoring many of these redundant events.
This PR also provides a workaround for #473, where one intensity sliders may shift unexpectedly and trigger a change in the other intensity slider. The workaround is simply to turn off this synchronization during intensity slider adjustments so that the user only needs to counter the unexpected shift in one slider.