Provide more error feedback during image import in the GUI #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging file path is set by the user or to a default path, but either may change depending on the available path locations for the rotating file handler. Store this path in `config` so that the path can be displayed to the user.
Errors during single file import have been assumed to result from RAW files but may occur for other reasons such as unrecognized or incompatible file types. Catch any `ValueError`s, skipping the file and notifying the user. Also, change the notification for conversion to RGB to grayscale so that it appears in the GUI.
The GUI has simply notified the user when the import could not be completed but has not provided explanations for the import error. Catch global exceptions during import to notify the user of the error and point them to the log file. This notification contains the basic error, while the full stack trace is posted to the console and log file. This notification has not been added to import through the command-line since presumably the error message would be visible in the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors that occur during image import have shown only limited feedback in the GUI, requiring the user to view the console or the log file to see more detailed error messages (see #82). For those using the installer version, the log file is not intuitive to locate. This PR provides more feedback in the GUI by reporting any error messages in the import feedback text area along with the path to the log file for more detailed info such as the stack trace.
A common source of import errors is importing a directory that may contain other, non-image files. This PR now simply skips individual file planes that give an error. To report the log path after errors that stop the import, the path is now stored in
configafter setting up the log path with any file rotation.