Test and document #3
Conversation
…nit tests on test-simplify.R
This file contains all 3 test cases compiled into 1 file.
…n unit test with causal.effect simp = TRUE
…ed out the simplify.R function file
delete previously-created simplify .Rd documentation in order to ensure no conflict with roxygen-created simplify (cannot modify .Rd files by hand; must use roxygen)
…d Encoding = UTF-8. Updated NAMESPACE file to include export(simplify). Updated simplify.R to include working documentation when ?simplify is run.
…simplify.Rd documentation. Added export(join) to NAMESPACE.
…ion documentation files with the test example.
…aph are causaleffect functions, not igraph.
…on file. Added an insert unit test to test case 1.
…matting changes to test case #2. Updated all_3_test_cases document to reflect changes. Began documenting powerset.R
…to fix unit tests for join and insert but did not succeed.
…ests for reproducibility
…d join.Rd files can now link to parse.expression as well.
…3/25 unit tests pass.
|
@hmhummel @djinnome thanks for the amazing work! I didn't even realize you had been working on the package. I see that some previously internal functions are now exported (simplify, join), is there some motivation for this? Also, some other internals have documentation files (parse.expression, powerset, insert), not sure if this is ok for CRAN or not. |
|
Hi @santikka this project was part of an internship that @hmhummel completed with me last summer. I have a python implementation of many causal, counterfactual, and transportability algorithms (including your surrogate outcomes algorithm) in a project called y0, and I read with interest your simplification paper. The goal of the internship was to implement your simplification algorithm in y0. However, aside from the paper itself, there was little documentation on the functions that implement the simplification algorithm, so our first step was to document those functions so that we (and hopefully others) understood how to use them. The second step was to port them to the python implementation of causaleffect, and the third step was to port from causaleffectpy to y0. Unfortunately, the internship ended before Haley could complete the 2nd and 3rd steps, but you can see the quality of her handiwork on step 1. |
Create unit tests and documentation for all previously undocumented, untested code that supports the simplify algorithm.