Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework twitter dashboard buttons to not use dynamic class names #3976

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Nov 6, 2023

Changes

Do not use classes like bg-#{@color}-600 but instead provide the full class name as argument: bg-red-600 and bg-green-600. Otherise Tailwind will purge these classes and they won't be included in the app.css file.

image

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff merged commit a08327d into master Nov 6, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the update-buttons-twitter-dashboard branch November 6, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant