Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Metric Registry Populate script #4511

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Dec 19, 2024

Changes

  • The old version of the populate script was causing constraint errors
  • Also break down the big populate function into multiple small ones

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff force-pushed the fix-metric-registry-populate branch from cf01ec7 to 0b19370 Compare December 19, 2024 13:55
@IvanIvanoff IvanIvanoff force-pushed the fix-metric-registry-populate branch from 0b19370 to 256f44e Compare December 19, 2024 14:58
@IvanIvanoff IvanIvanoff force-pushed the fix-metric-registry-populate branch from 256f44e to 42ce2c1 Compare December 19, 2024 15:21
@IvanIvanoff IvanIvanoff merged commit 431a4e3 into master Dec 20, 2024
4 checks passed
@IvanIvanoff IvanIvanoff deleted the fix-metric-registry-populate branch December 20, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant