Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected response and add error reports to price scraper #4516

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Jan 3, 2025

Changes

  • Reorder the Tesla middlewares as the Logger middleware returned errors if placed last.
  • Pattern match to avoid attempting to treat nil as a list.
  • Add log message so we can track what exactly is missing.

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff merged commit a2c1da5 into master Jan 3, 2025
4 checks passed
@IvanIvanoff IvanIvanoff deleted the fix-price-scraper branch January 3, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant