feature/JC-713-genre-list-feature-react #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t value to Filter JC-713
datngo-saritasa
requested review from
a team,
Totoblak90,
shalomich,
SofyaKirillova and
LocTran-saritasa
and removed request for
a team
datngo-saritasa
changed the title
|
LocTran-saritasa
requested changes
Aug 24, 2024
apps/react/src/features/genres/components/GenreSearch/GenreSearch.tsx
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenreSearch/GenreSearch.tsx
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenreSearch/GenreSearch.tsx
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenresFilter/GenresFilter.tsx
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenresSort/GenresSort.tsx
Outdated
Show resolved
Hide resolved
…saritasa-nest/camp-js-2024-anastasia-fongrad into feature/JC-713-genre-list-feature-react and Fix PR reviews
|
datngo-saritasa
changed the base branch from
develop
to
feature/JC-716-anime-studio-list
pavelzadorin-saritasa
requested review from
AndreySkripachev
and removed request for
Totoblak90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All genre related features should be implemented in one standalone project feature (
react/src/features/genre)A list of genres should be placed on left sidebar and detail info in a main content block.
List contains fields:
name
type
I have used the Material UI library for UI. For Material UI use List component: https://mui.com/material-ui/react-list/
Add auxiliary features to manage list display
Add infinite scroll to navigate of whole genre list (google for
intersection observerto make the correct implementation) for that use /api/v1/anime/genres/list-cursor/` api method;Add sorting by fields: name, type.
Add searching feature.
Add filtering by type. Additional possibility to chose multiple types for filtering has added.
All features have implemented in server-side way.
The current/selected values for pagination, sorting, filtering should be stored in the URL, so that it would be possible to send a link to the list with the configured parameters.