Feature: Displaying Details for A Selected Anime JC-692 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manpham-saritasa
requested review from
a team,
ShestakovaElena and
karbik-creator
and removed request for
a team
|
Comment on lines
+69
to
+76
| private mapGenreListFromDto(dto: AnimeDetailDto['genres_data']): AnimeDetail['genreList'] { | ||
| return dto.map(genreDto => this.genreMapper.fromDto(genreDto)); | ||
| } | ||
|
|
||
| private mapGenreListToDto(model: AnimeDetail['genreList']): AnimeDetailDto['genres_data'] { | ||
| return model.map(genre => this.genreMapper.toDto(genre)); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure there is any reason to add these additional methods for lists.
It increases the amount of TS types we see, which we have to read and process... but if you did everything correctly, all needed them will be showed on hover
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a feature for displaying details for a selected anime.
By clicking on row into animes table the app has to be navigated to standalone URL of page with Anime detail info.
Detail page contains:
all fields from Table page
Detail page has:
Opening this page is not allowed for unauthenticated users.