Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Avoid warnings about ObjectStorage with PHPStan 1.11.9 #168

Merged

Conversation

oliverklee
Copy link
Collaborator

It looks like PHPStan 1.11.9 considers the offending line to be different in version 1.11.9.

To be compatible with both PHPStan <= 1.11.9 and 1.11.9, we now need two @phpstan-ignore-next-line entries.

Fixes #167

It looks like PHPStan 1.11.9 considers the offending line to be
different in version 1.11.9.

To be compatible with both PHPStan <= 1.11.9 and 1.11.9, we now
need two `@phpstan-ignore-next-line` entries.

Fixes sascha-egerer#167
@sascha-egerer sascha-egerer merged commit 85ff3e4 into sascha-egerer:master Aug 3, 2024
20 checks passed
@oliverklee oliverklee deleted the bugfix/ignore-storage-key branch August 3, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Return type of ObjectStorage::key() with PHPStan 1.11.9 and TYPO3 12LTS
2 participants