Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Align the stubs with the code of the TYPO3 11LTS Core #96

Closed
wants to merge 1 commit into from
Closed

[TASK] Align the stubs with the code of the TYPO3 11LTS Core #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stubs/ObjectStorage.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,36 @@
* @param TEntity $value
* @param mixed $information
*/
#[\ReturnTypeWillChange]
public function offsetSet($value, $information);

/**
* @param TEntity|int $value
* @return bool
*/
#[\ReturnTypeWillChange]
public function offsetExists($value);

/**
* @param TEntity|int $value
*/
#[\ReturnTypeWillChange]
public function offsetUnset($value);

/**
* @param TEntity|int $value
* @return ($value is int ? TEntity|null : mixed)
*/
#[\ReturnTypeWillChange]
public function offsetGet($value);

/**
* This is different from the SplObjectStorage as the key in this implementation is the object hash (string).
* @phpstan-ignore-next-line See https://forge.typo3.org/issues/98146
* @return string|null
*/
#[\ReturnTypeWillChange]
public function key();

Check failure on line 50 in stubs/ObjectStorage.stub

View workflow job for this annotation

GitHub Actions / Tests (^11.5, 7.4) 

Return type (string|null) of method TYPO3\CMS\Extbase\Persistence\ObjectStorage::key() should be compatible with return type (int) of method Iterator<int,TEntity>::key()

Check failure on line 50 in stubs/ObjectStorage.stub

View workflow job for this annotation

GitHub Actions / Tests (^11.5, 7.4, --prefer-lowest) 

Return type (string|null) of method TYPO3\CMS\Extbase\Persistence\ObjectStorage::key() should be compatible with return type (int) of method Iterator<int,TEntity>::key()

/**
* @return array<TEntity>
Expand Down
Loading