Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.9.0 #100

Closed
wants to merge 1 commit into from
Closed

Update sbt to 1.9.0 #100

wants to merge 1 commit into from

Conversation

scala-center-steward[bot]
Copy link
Contributor

Updates org.scala-sbt:sbt from 1.8.3 to 1.9.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 6, 2023

[error] sbt.librarymanagement.ResolveException: Error downloading org.scalameta:semanticdb-scalac_2.12.18:4.6.0

Scalameta 4.6.0 is brought by Scalafix 0.10.4. It looks like https://search.maven.org/solrsearch/select?q=g:%22ch.epfl.scala%22+AND+a:%22sbt-scalafix%22&rows=10&wt=xml is stale as it does not return 0.11.0.

@julienrf
Copy link

julienrf commented Jun 6, 2023

I’ve noticed some issues with the search tool, but the artifacts are there: https://repo1.maven.org/maven2/ch/epfl/scala/sbt-scalafix_2.12_1.0/0.11.0/

@julienrf
Copy link

julienrf commented Jun 6, 2023

Do we need to update both sbt and sbt-scalafix?

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 8, 2023

I’ve noticed some issues with the search tool, but the artifacts are there: https://repo1.maven.org/maven2/ch/epfl/scala/sbt-scalafix_2.12_1.0/0.11.0/

Right, the problem is that the link I posted above is used internally in giter8, so now that the default in sbt 1.9.0 is scala 2.12.18, the latest version of scalafix supporting it is needed.

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 8, 2023

Do we need to update both sbt and sbt-scalafix?

Both are driven by sbt-scalafix, so it does look like the problem is related to the search response. I don't see how, but I'll see later if this might be caused by the double POM publishing introduced in 1.9.0 (used to publish sbt-scalafix 0.11.0).

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 8, 2023

I don't see how, but I'll see later if this might be caused by the double POM publishing introduced in 1.9.0 (used to publish sbt-scalafix 0.11.0).

It really doesn't look like it, so I filed foundweekends/giter8#802

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 8, 2023

Trying things in #102 to unblock that (and fix the underlying issue of stale version)

@scala-center-steward
Copy link
Contributor Author

Superseded by #103.

@scala-center-steward scala-center-steward bot deleted the update/sbt-1.9.0 branch June 27, 2023 00:21
@bjaglin bjaglin mentioned this pull request Jun 30, 2023
@bjaglin bjaglin mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants