fix maptype doesn't use the frameless injection properly #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @thesamet |
|
Can you rebase so the change is tested in CI? Also are the changes in |
ukby1234
force-pushed
the
fix-map-type-injection
branch
from
7ca5802 to
f5c0165
Compare
Just rebased. No they are not necessary but I only have jdk 17 installed. |
|
@thesamet friendly bump |
thesamet
reviewed
Jan 23, 2025
build.sbt
Outdated
| @@ -105,7 +105,25 @@ lazy val `sparksql-scalapb` = (projectMatrix in file("sparksql-scalapb")) | |||
| scalapbPlugin(scalapb.value.scalapbVersion) -> (Test / sourceManaged).value | |||
| ), | |||
| Test / run / fork := true, | |||
| Test / javaOptions ++= Seq("-Xmx2G") | |||
| Test / fork := true, | |||
There was a problem hiding this comment.
Can this be moved and explored on a different PR?
There was a problem hiding this comment.
@thesamet friendly bump
ukby1234
force-pushed
the
fix-map-type-injection
branch
from
f5c0165 to
3e9715b
Compare
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix test forking and add jvm flags to run tests in jdk17.