Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala3-compiler to 3.6.2 #904

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scala-lang:scala3-compiler from 3.5.2 to 3.6.2

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-compiler" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-compiler" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@saeltz
Copy link
Collaborator

saeltz commented Dec 24, 2024

Update fails the ScapegoatPhaseTest with a NullPointerException thrown in dotty.tools.dotc.core.Phases.scala:391. @Johnnei, do you have a clue?

@Johnnei
Copy link
Contributor

Johnnei commented Dec 26, 2024

I found that scala/scala3#21651 made more of the internal state of the compiler required to be set correctly. As I mostly wanted to validate it could generate the reports at all I wanted to skip running the entire compiler. As this turns out to be brittle, let's just reuse the inspection test framework for it to avoid this complexity at maybe a bit slower run time. Will raise PR to do so shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants