Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SlimChannel and SlimThread converters #218

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

clari7744
Copy link
Contributor

Note

1.5 years and 145-some commits later, I remembered that I was rebasing my master branch onto your master branch, finished that, and had the motivation to look at my old branches. "This" branch was hopelessly out of date, so I just deleted and re-forked. Everything should be rebased properly since it's a fresh fork, so hopefully no complaining this time?
Original PR @ #127

Rationale

This avoids channel names conflicting with channel names. It may be an edge case, but I have a channel called bots and a command called bots, and the Greedy for overrides was eating my command.

Summary of changes made

I basically copied the logic for the SlimUserConverter and applied it to TextChannels and Threads, hopefully with the correct v2 logic.
Note that it's not really friendly to pre-v2 so if you want me to patch that I certainly can, wasn't sure if it's still being supported or not now that v2 is on PyPI.

Checklist

  • This PR changes the jishaku module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

@scarletcafe scarletcafe merged commit 32009b4 into scarletcafe:master Nov 12, 2023
13 checks passed
@clari7744 clari7744 deleted the more-slim-converters branch November 14, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants