Add SlimChannel and SlimThread converters #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
1.5 years and 145-some commits later, I remembered that I was rebasing my master branch onto your master branch, finished that, and had the motivation to look at my old branches. "This" branch was hopelessly out of date, so I just deleted and re-forked. Everything should be rebased properly since it's a fresh fork, so hopefully no complaining this time?
Original PR @ #127
Rationale
This avoids channel names conflicting with channel names. It may be an edge case, but I have a channel called
bots
and a command calledbots
, and the Greedy for overrides was eating my command.Summary of changes made
I basically copied the logic for the SlimUserConverter and applied it to TextChannels and Threads, hopefully with the correct v2 logic.
Note that it's not really friendly to pre-v2 so if you want me to patch that I certainly can, wasn't sure if it's still being supported or not now that v2 is on PyPI.
Checklist