Merge pull request #3 from mtlewis/bug/info-properties-never-set

(bugfix) Fix setting of info properties on pdfs
schibsted · Jul 30, 2018 · e1db088 · e1db088
2 parents c96b6a4 + 818ff11
commit e1db088
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -178,7 +178,7 @@ export function toPDFMake(tag) {
 
   const info = pick(attributes, ['title', 'author', 'subject', 'keywords']);
 
-  if (info.length > 0) {
+  if (Object.keys(info).length > 0) {
     result.info = info;
   }
 

diff --git a/src/index.test.js b/src/index.test.js
@@ -431,7 +431,17 @@ describe('#jsx-pdf', () => {
       });
     });
 
-    it('should error if a top level element appears below the top level', () => {
+    ['title', 'author', 'subject', 'keywords'].forEach(field => {
+      it(`should set ${field} in info`, () => {
+        expect(toPDFMake(<document {...{ [field]: 'foo' }} />)).toEqual({
+          info: {
+            [field]: 'foo',
+          },
+        });
+      });
+    });
+
+    it('should error if a top-level element appears below the top level', () => {
       expect(() => {
         toPDFMake(
           <document>