Implementation of a Max Depth for member scanning #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the DepthLimit attribute and the ability to set depth limits in the Fluent Config.
If the DepthLimit is set for a specific column, that column will not explore all the possible branches but rather stop after computing all the paths with a maximum distance of N from its source.
As an example, if you set it like:
c.Column(m => m.MyProp).Reference( m => m.Id, ReferenceType.OneToOne).LimitMappingDepth(2)That means that it will explore all the members in MyProp, if it finds child members in MyChildProp it will explore those too, but then it will not go further away from MyProp (depth 2 reached).
The loop protection is still valid and in place, but this adds to it and is invaluable if you have data structures with several foreign keys that can branch, as the flattening of that tree can lead to hundreds of thousands of possible paths.
Use as a typical NPoco column attribute or at the end of a Column or Many declaration in fluent config.