Use converters for ExecuteScalar calls #665
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update, rather than just trying to convert an ExecuteScalar result type using
Converter.ChangeType
it uses the mappers registered with the database to allow more fine grained conversions. This will be useful for things like SQLite where it stores Guids as strings, but there is no direct conversion between string and Guid in C# so this would result in an exception, where as with this fix, an explicit converter can be added (or actually in this partiaucalr example, there is code in the mapping helper to handle this exact string > Guid scenario)This fixes #664 and #653