Add support for multiple certificates #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows `customCertificate` entry to be an array of objects. Each object describes a single certificate entry, using the supported options. The change is fully backwards compatible (object type `customCertificate` works exactly as it did before). Also some functions are now `async`. Tested with serverless 3.1.1 TODO: think about the return values + there's one variable resolver that I can't test (requires older serverless probably?)
|
This fixes #47 |
|
LGTM |
|
+1 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
customCertificateentry to be an array of objects.Each object describes a single certificate entry, using the supported
options.
The change is fully backwards compatible (object type
customCertificateworks exactly as it did before).Also some functions are now
async.Tested with serverless 3.1.1
TODO:
getCertificatePropertyOlddidn't seem to be called by anything. It's likely something used in older versions? Needs to be checked and ported there too