Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): added python3.11 and python3.12 tests #447

Closed

Conversation

marekschneider
Copy link

Proposed Changes

@Buedenbender
Copy link

Highly appreciated and anticipated.
Thank you very much

@PaulWestenthanner
Copy link
Collaborator

The github action pipeline fails as python 3.7 is no longer supported by them.
I just checked and python 3.8 also reached the end of life, so we should probably remove 3.7 and 3.8

@PaulWestenthanner
Copy link
Collaborator

PaulWestenthanner commented Dec 28, 2024

seems like we're not compatible with sklearn >= 1.6.

Quick fix would be to specify this in requirements.txt and create an issue (or properly fit it).

I'm currently working on a rather big change that should add type hinting, update all dependencies and re-work the tooling including a pipeline that does type checking and format checking etc.
https://github.com/PaulWestenthanner/categorical-encoding/tree/improve_type_hints
Not sure when this will be done but it will fix compatibility issues as well

@PaulWestenthanner
Copy link
Collaborator

I've added support. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants