Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX forward properly the metadata with the pipeline #1115

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

glemaitre
Copy link
Member

closes #1111

This PR fixes a bug in Pipeline that properly defines how metadata should be routed with a sampler.

@glemaitre glemaitre merged commit 88f057d into master Dec 20, 2024
29 checks passed
@glemaitre glemaitre deleted the is/1111 branch December 20, 2024 16:25
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (e32819e) to head (5cd7d37).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   92.98%   93.87%   +0.89%     
==========================================
  Files         105       54      -51     
  Lines        8323     3610    -4713     
  Branches     1288      486     -802     
==========================================
- Hits         7739     3389    -4350     
+ Misses        465      124     -341     
+ Partials      119       97      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Allow fit_resample to receive metadata routed parameters
1 participant