-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features #49
Open
fayeab
wants to merge
18
commits into
scikit-learn-contrib:master
Choose a base branch
from
fayeab:new_features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New features #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs based on confusion matrix (precision, recall, ...)
…meter instead of 4
Check the parameters of SkopeRules Remove precision_min and recall_min parameters Signed-off-by: fayeab <fayablaye@gmail.com>
Signed-off-by: fayeab <fayablaye@gmail.com>
Signed-off-by: fayeab <fayablaye@gmail.com>
Signed-off-by: fayeab <fayablaye@gmail.com>
….base and sklearn.utils.testing modules are deprecated in version 0.22 and will be removed in version 0.24 Signed-off-by: fayeab <fayablaye@gmail.com>
…datasets.base and sklearn.utils.testing modules are deprecated in version 0.22 and will be removed in version 0.24" This reverts commit 38e7ce4.
This reverts commit 3c0ed2b.
This reverts commit d1f48fe.
Signed-off-by: fayeab <fayablaye@gmail.com>
Signed-off-by: fayeab <fayablaye@gmail.com>
…removed in version 0.24. Signed-off-by: fayeab <fayablaye@gmail.com>
…utils.testing modules are deprecated in version 0.22 and will be removed in version 0.24 Signed-off-by: fayeab <fayablaye@gmail.com>
…e_weight. This parameter is not use in same way by skrules. Signed-off-by: fayeab <fayablaye@gmail.com>
Thanks @fayeab for the good work
These PRs do not need to be independent and are probably to be based on each others |
…not allowed by scikit-learn checks in version 0.24. All init parameters have to be immutable to make cloning possible. Signed-off-by: fayeab <fayablaye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42
Hello,
I've added two features (filtering and deduplication criteria) for skope rules.
This work is an improvement of #42
We have 3 new parameters for SkopeRule class :