Skip to content

Commit

Permalink
reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
adrinjalali committed Jan 2, 2025
1 parent aaeee6d commit 71f2fea
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions _posts/2024-12-05-dev-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,9 @@ cycle warning.
In the past few releases, we've slowly introduced more functionalities under this
umbrella. `__sklearn_clone__` and `__sklearn_is_fitted__` are two examples.

In the latest release, at the time of writing this post, we focused on the testing
infrasutructure and estimator tag system. Estimator tags used to be private, and we
were not sure about their design. In the 1.6 release, new tags are introduced and
using them looks like the following:
In the 1.6 release, we focused on the testing infrastructure and estimator tag system.
Estimator tags used to be private, and we were not sure about their design. In the 1.6
release, new tags are introduced and using them looks like the following:

```python
from sklearn.base import BaseEstimator, ClassifierMixin
Expand All @@ -75,7 +74,7 @@ class MyEstimator(ClassifierMixin, BaseEstimator):
```

The new tags mostly follow the same structure as the old tags, but there are certain
changes to them. The main change is that the old `_xfail_checks` is no more present
changes to them. The main change is that the old `_xfail_checks` is no longer present
in the new tags. That tag was used to tell the common testing tools about the tests
which are known to fail and are to be skipped. That information is now directly passed
to the test functionalities. The old way of skipping a test was the following:
Expand Down Expand Up @@ -123,13 +122,13 @@ def test_with_parametrize_with_checks(estimator, check):
```

While working on the testing infrastructure, we have also been working on improving our
tests and that means in this release we had a particularly higher number of changes in
their names and what they do. The changes should have made it easier for developers to
fix issues with their estimators. Note that you can now pass `legacy=False` to both
tests and that means in this release we had a particularly high number of changes in
their names and what they do. The changes will make it easier for developers to fix
issues with their estimators. Note that you can now pass `legacy=False` to both
`check_estimator` and `parametrize_with_checks` to include only strictly API related
tests.

The above changes means developers need to updated their estimators and depending on
The above changes mean developers need to update their estimators and depending on
what they use, write scikit-learn version specific code to handle supporting multiple
scikit-learn versions. To make that process easier, we've worked on a package called
[`sklearn_compat`](https://github.com/sklearn-compat/sklearn-compat/). You can either
Expand Down

0 comments on commit 71f2fea

Please sign in to comment.