Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final connectivity scripts PR #1099

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

EmmaRenauld
Copy link
Contributor

Quick description

  • Graph_measures: ok
  • connectivity_math: There was no check that the ref_matrix exists. Using the load_matrix method to do this check.
  • connectivity_filter:
    - Added ref to Jasmeen's thesis
    - Fix number in logging (said the number <, should have been <=)
    - Simplify the code

@pep8speaks
Copy link

pep8speaks commented Dec 12, 2024

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-18 03:35:16 UTC

@EmmaRenauld EmmaRenauld requested a review from frheault December 12, 2024 19:13
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 24 lines in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (e256482) to head (8e24556).
Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1099   +/-   ##
=======================================
  Coverage   69.46%   69.46%           
=======================================
  Files         447      448    +1     
  Lines       24052    24080   +28     
  Branches     3291     3291           
=======================================
+ Hits        16708    16728   +20     
- Misses       5946     5959   +13     
+ Partials     1398     1393    -5     
Components Coverage Δ
Scripts 70.11% <27.27%> (-0.15%) ⬇️
Library 68.60% <ø> (+0.20%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants