Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fibertube Density #1112

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Fibertube Density #1112

wants to merge 30 commits into from

Conversation

VincentBeaud
Copy link
Contributor

@VincentBeaud VincentBeaud commented Dec 17, 2024

Quick description

New script that estimates the volumetric density of a set of fibertubes (How much volume is fibertubes versus how much volume is emptiness) using a uniform array of samples.

Outputs:

  • Density map
  • Density metrics
  • Collision map. (In each voxel, the ratio of samples that arrive in two or more fibertubes)

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Volumetric density map
image

Collision density map
(Even parallel fibertubes collide here, because I used very big diameters)
image

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VincentBeaud VincentBeaud marked this pull request as ready for review December 17, 2024 18:44
@VincentBeaud
Copy link
Contributor Author

@CHrlS98 @gabknight Voici la PR pour les maps de densité et de collisions.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 18 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (0ac4461) to head (b46cc83).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   69.56%   69.61%   +0.04%     
==========================================
  Files         448      449       +1     
  Lines       24078    24179     +101     
  Branches     3290     3312      +22     
==========================================
+ Hits        16751    16833      +82     
- Misses       5934     5946      +12     
- Partials     1393     1400       +7     
Components Coverage Δ
Scripts 70.32% <82.05%> (+0.07%) ⬆️
Library 68.67% <92.59%> (+0.01%) ⬆️

scripts/tests/test_fibertube_compute_density.py Outdated Show resolved Hide resolved
scripts/scil_fibertube_compute_density.py Outdated Show resolved Hide resolved
scripts/scil_fibertube_compute_density.py Outdated Show resolved Hide resolved
scripts/scil_fibertube_compute_density.py Outdated Show resolved Hide resolved
scripts/scil_fibertube_compute_density.py Outdated Show resolved Hide resolved
scripts/scil_fibertube_compute_density.py Show resolved Hide resolved
scilpy/tractanalysis/fibertube_scoring.py Outdated Show resolved Hide resolved
@VincentBeaud VincentBeaud requested a review from CHrlS98 December 19, 2024 20:03
@VincentBeaud
Copy link
Contributor Author

@CHrlS98 C'est fait, je t'invite à rechecker vite vite, ça fait un bout que j'ai pas codé haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants