-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fibertube Density #1112
Open
VincentBeaud
wants to merge
30
commits into
scilus:master
Choose a base branch
from
VincentBeaud:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fibertube Density #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@CHrlS98 @gabknight Voici la PR pour les maps de densité et de collisions. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
+ Coverage 69.56% 69.61% +0.04%
==========================================
Files 448 449 +1
Lines 24078 24179 +101
Branches 3290 3312 +22
==========================================
+ Hits 16751 16833 +82
- Misses 5934 5946 +12
- Partials 1393 1400 +7
|
CHrlS98
requested changes
Dec 18, 2024
CHrlS98
reviewed
Dec 19, 2024
@CHrlS98 C'est fait, je t'invite à rechecker vite vite, ça fait un bout que j'ai pas codé haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
New script that estimates the volumetric density of a set of fibertubes (How much volume is fibertubes versus how much volume is emptiness) using a uniform array of samples.
Outputs:
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
Volumetric density map
Collision density map
(Even parallel fibertubes collide here, because I used very big diameters)
Checklist