Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to dipy 1.10 #1114

Merged
merged 1 commit into from
Jan 9, 2025
Merged

update to dipy 1.10 #1114

merged 1 commit into from
Jan 9, 2025

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Dec 20, 2024

Quick description

Update to dipy 1.10

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.54%. Comparing base (c352faf) to head (0eb5b4d).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   69.54%   69.54%           
=======================================
  Files         448      448           
  Lines       24069    24069           
  Branches     3289     3289           
=======================================
  Hits        16739    16739           
  Misses       5938     5938           
  Partials     1392     1392           
Components Coverage Δ
Scripts 70.25% <ø> (ø)
Library 68.60% <100.00%> (ø)

Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, then good to go.

@arnaudbore arnaudbore added this pull request to the merge queue Jan 9, 2025
Merged via the queue into scilus:master with commit d4ab899 Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants