Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov/codecov-action from 3 to 4 #111

Merged
merged 1 commit into from
Mar 6, 2024
+1 −1
Merged

Bump codecov/codecov-action from 3 to 4 #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ jobs:
run: yarn test

- name: Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Codecov token not found. Please provide Codecov token with -t flag.

since v4, a token input is no longer optional. See: https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. I will merge these dependabot PRs after the new cancellation feature is merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, token input is mandatory only for private repos. I think this does not apply for us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see: https://github.com/sclorg/testing-farm-as-github-action/actions/runs/7740868344/job/21106734628?pr=111#step:8:27

You can try to merge it as is and check if code coverage will be updating without token.

Loading