-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel Running TF Test Requests when action was canceled 🚥 #121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 99.18% 99.29% +0.10%
==========================================
Files 6 8 +2
Lines 491 564 +73
Branches 53 61 +8
==========================================
+ Hits 487 560 +73
Misses 4 4 ☔ View full report in Codecov by Sentry. |
In post step, we will send cancel request to TF to cancel pending Test run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. Please see my comments.
Also could you please add a brief information to readme, about need of setting:
concurrency:
group: ${{ github.head_ref }}
cancel-in-progress: true
in the users' action in order for this new functionality to work?
Sorry, now I see there is separate PR for the docs part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. LGTM.
TODO:
Fixes: