Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel Running TF Test Requests when action was canceled 🚥 #121

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Cancel Running TF Test Requests when action was canceled 🚥 #121

merged 4 commits into from
Mar 5, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Feb 20, 2024

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e246ab) 99.18% compared to head (a30eac0) 99.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   99.18%   99.29%   +0.10%     
==========================================
  Files           6        8       +2     
  Lines         491      564      +73     
  Branches       53       61       +8     
==========================================
+ Hits          487      560      +73     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku jamacku marked this pull request as ready for review February 21, 2024 15:03
Copy link
Collaborator

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Please see my comments.
Also could you please add a brief information to readme, about need of setting:

concurrency: 
  group: ${{ github.head_ref }}
  cancel-in-progress: true

in the users' action in order for this new functionality to work?

src/state.ts Show resolved Hide resolved
src/state.ts Show resolved Hide resolved
@zmiklank
Copy link
Collaborator

Also could you please add a brief information to readme, about need of setting:

concurrency: 
  group: ${{ github.head_ref }}
  cancel-in-progress: true

in the users' action in order for this new functionality to work?

Sorry, now I see there is separate PR for the docs part.

Copy link
Collaborator

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@zmiklank zmiklank merged commit 607d616 into sclorg:main Mar 5, 2024
5 checks passed
@jamacku jamacku deleted the post branch March 5, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants