Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript - fix parsing of tf responses and improve error handling #85

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Typescript - fix parsing of tf responses and improve error handling #85

merged 3 commits into from
Nov 27, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Nov 27, 2023

Let's parse only parts of JSON responses from TF that we use - fixes https://github.com/sclorg/nginx-container/actions/runs/7005842261

Also, set the status to error when we catch some.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a462b66) 94.15% compared to head (3aa3e32) 94.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           typescript      #85      +/-   ##
==============================================
+ Coverage       94.15%   94.45%   +0.29%     
==============================================
  Files               3        4       +1     
  Lines             428      451      +23     
  Branches           35       35              
==============================================
+ Hits              403      426      +23     
  Misses             25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phracek phracek merged commit 78edd92 into sclorg:typescript Nov 27, 2023
5 checks passed
zmiklank pushed a commit that referenced this pull request Jan 18, 2024
)

* fix: parse from tf response only things that we use

* refactor: pass pr object directly to action()

* fix: set status to failed when error occurs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants