Adds activity page #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chalhotra
requested changes
Jan 4, 2025
There was a problem hiding this comment.
put the activities list in the common hardcoded data file, presentation layer mein directly aise data ni hona chahiye ig
Chalhotra
reviewed
Jan 8, 2025
There was a problem hiding this comment.
svg not required if we already have a png of the same
There was a problem hiding this comment.
Woh png and svg dono nhi load ho rhe, they will mostly be removed. Mai karta
Chalhotra
reviewed
Jan 8, 2025
There was a problem hiding this comment.
can we make this using widgets instead of using an svg🥲
There was a problem hiding this comment.
Idts yeh finally aega bhi kyunki accounts integration pr dependant hai
Chalhotra
reviewed
Jan 8, 2025
There was a problem hiding this comment.
yeh gitignore nahi hoga toh add ho gaya hoga, ill remove
Chalhotra
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.