FIX: Record Broken on Some Devices

README.md

@@ -39,9 +39,9 @@ sadb scrcpy
     - Start scrcpy on a device
 sadb ip 
     - Get the selected device's IP address
-sadb screenshot myScreenshot.png 
+sadb screenshot -f myScreenshot.png 
     - Take a screenshot of a device
-sadb record myVideo.mp4 
+sadb record -f myVideo.mp4 
     - Record the screen of a device (Press CTRL-C to stop recording)
 sadb wifi 
     - Connect to a device via WiFi

sadb.py

@@ -16,7 +16,7 @@ def split_get_devices(result):
 
 
 def get_devices():
-    result = subprocess.run(["adb", "devices"], capture_output=True, text=True)
+    result = subprocess.run(["adb", "devices"], capture_output=True, text=True, check=False)
     return split_get_devices(result.stdout)
 
 
@@ -114,7 +114,7 @@ def screenshot(device, filename):
 def record(device, filename):
     if not filename:
         filename = "video.mp4"
-    remote_path = "/sdcard/screenrecord.mp4"
+    remote_path = "/data/local/tmp/screenrecord.mp4"
 
     cmd = ["adb", "-s", device, "shell", f"screenrecord {remote_path}"]
     proc = subprocess.Popen(cmd)
@@ -137,6 +137,7 @@ def record(device, filename):
     subprocess.run(cmd)
 
 
+
 def wifi(device):
     ip_address = get_ip(device)
 
@@ -295,6 +296,7 @@ def main():
             screenshot(device, args.filename)
 
         elif args.command == "record":
+            print(args.filename)
             device = select_device(devices)
             if device is None:
                 return

tests/test_commands.py

@@ -92,7 +92,7 @@ def test_screenshot_custom_name():
 
 def test_record_custom_name():
     filename = "custom.mp4"
-    remote_path = "/sdcard/screenrecord.mp4"
+    remote_path = "/data/local/tmp/screenrecord.mp4"
 
     mock_proc = MagicMock()
     with patch("subprocess.Popen", return_value=mock_proc) as mock_popen, \
@@ -109,7 +109,7 @@ def test_record_custom_name():
 
 def test_record_default_name():
     filename = "video.mp4"
-    remote_path = "/sdcard/screenrecord.mp4"
+    remote_path = "/data/local/tmp/screenrecord.mp4"
 
     mock_proc = MagicMock()
     with patch("subprocess.Popen", return_value=mock_proc) as mock_popen, \