Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: General Cleanup & Recording Fix (Again...) #6

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

seamus-sloan
Copy link
Owner

What's New?

There were a lot of squiggly lines from Pylint that needed to get handled. This involved some reordering of imports, adding doc strings, and renaming variables. Some Pylint warnings were suppressed in each file (Docstrings don't need to be added to test functions if the tests are named correctly).

Recording was tweaked (again...) since the issue was able to be reproduced on my Pixel 4 XL. I believe the issue is now about waiting for the device to save the video file to the location -- not the location itself. I do prefer the /data/local/tmp directory to the /sdcard/ directory, though, so that has stayed the same.

After adding another sleep to the record() function and allowing the user to have the option to delete the recording from the device, the record tests needed to be updated to account for the extra sleep and another test was added to ensure that the delete call is ONLY called when the user specified it to.

Checklist

  • Tests pass?
  • App runs?

Notes

:)

@seamus-sloan seamus-sloan merged commit cdd0a84 into main Oct 24, 2023
@seamus-sloan seamus-sloan deleted the fixes/general-cleanup branch October 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant