FIX: General Cleanup & Recording Fix (Again...) #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
There were a lot of squiggly lines from Pylint that needed to get handled. This involved some reordering of imports, adding doc strings, and renaming variables. Some Pylint warnings were suppressed in each file (Docstrings don't need to be added to test functions if the tests are named correctly).
Recording was tweaked (again...) since the issue was able to be reproduced on my Pixel 4 XL. I believe the issue is now about waiting for the device to save the video file to the location -- not the location itself. I do prefer the
/data/local/tmp
directory to the/sdcard/
directory, though, so that has stayed the same.After adding another sleep to the
record()
function and allowing the user to have the option to delete the recording from the device, therecord
tests needed to be updated to account for the extra sleep and another test was added to ensure that the delete call is ONLY called when the user specified it to.Checklist
Notes
:)