Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composable pipe for async functions #129

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix composable pipe for async functions #129

merged 2 commits into from
Jan 22, 2024

Conversation

diogob
Copy link
Contributor

@diogob diogob commented Jan 22, 2024 •
edited
Loading

The types PipeArguments and PipeReturn were not taking into account async composables (the runtime already had the proper awaits though).

The fix using Awaited caused functions returning never to type check, so I introduced the IsNever and handled those cases separately.

@diogob diogob marked this pull request as draft January 22, 2024 19:54
gustavoguichard
gustavoguichard previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@gustavoguichard gustavoguichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogob diogob marked this pull request as ready for review January 22, 2024 19:59
@diogob diogob merged commit b41217a into main Jan 22, 2024
2 checks passed
@diogob diogob deleted the fix-compositions-on-async-failing branch January 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavoguichard gustavoguichard gustavoguichard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogob @gustavoguichard