No implicit any #147
Merged
No implicit any #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavoguichard
commented
Jun 7, 2024
| @@ -110,7 +116,7 @@ describe('fromSuccess', () => { | |||
| const a = composable(() => 1) | |||
|
|
|||
| const c = fromSuccess(a) | |||
| type _R = Expect<Equal<typeof c, () => Promise<number>>> | |||
| type _R = Expect<Equal<typeof c, () => Promise<1>>> | |||
There was a problem hiding this comment.
@diogob I don't know why it changed.. narrower seems better. Didn't break any other test... any ideas?
There was a problem hiding this comment.
I don't understand, but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #146
This seemed to be impossible, I've done a lot of research and created an X thread with some experts.
The solutions seemed to be:
anyat all which seems reasonable(...args: any[]) => anyfor(...args: never[]) => unknown. This one was suggested by our contributor @jly36963 which is a thread on TS repo itself, and it seems nice because if you don't declare the types the arguments are gonna be never so you can't use them. I was a bit worried about some comments about problems with default arguments - as you can read in the last comment on that thread.This morning I decided to try and use the
Functionprimitive. I know we are not supposed to use it for several reasons (it could mean any constructor, or callable object, etc) but it seems to do it here.WDYT?