feature(banira): docs page layout improv

sebs · Jan 4, 2025 · ce1b939 · ce1b939
1 parent ba101c4
commit ce1b939
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/packages/banira/src/formatter/doc-page.ts b/packages/banira/src/formatter/doc-page.ts
@@ -34,15 +34,22 @@ export class FormatterDocPage {
     <link
         rel="stylesheet"
         href="https://cdn.jsdelivr.net/npm/@picocss/pico@2/css/pico.min.css"
-    >
+    />
 </head>
 <body>
-    <header>
+    <header class="container">
+        <hgroup>
         <h1>${title}</h1>
+        </hgroup>
     </header>
-    <main>
+    <main class="container">
+        <section id="preview">
         <${tagName}></${tagName}>
+        </section>
     </main>
+    <footer class="container">
+      <small>Built with banira</small>
+    </footer>
 </body>
 </html>`
     }

diff --git a/packages/component-webaudio/src/wa-knob.ts b/packages/component-webaudio/src/wa-knob.ts
@@ -14,8 +14,6 @@ class WAKnob extends HTMLElement {
 
     constructor() {
         super();
-        this.attachShadow({ mode: 'open' });
-        this.render();
     }
 
     get value() {
@@ -105,6 +103,8 @@ class WAKnob extends HTMLElement {
     }
 
     connectedCallback() {
+        this.attachShadow({ mode: 'open' });
+
         // Initialize from attributes if present
         if (this.hasAttribute('min')) {
             this.min = parseFloat(this.getAttribute('min') || '0');
@@ -130,6 +130,7 @@ class WAKnob extends HTMLElement {
         this.setAttribute('min', this._min.toString());
         this.setAttribute('max', this._max.toString());
         this.setAttribute('default', this._default.toString());
+        this.render();
     }
 
     private render() {
@@ -168,7 +169,7 @@ class WAKnob extends HTMLElement {
                     text-align: center;
                 }
             </style>
-            <div class='knob-body'>
+            <div class="knob-body">
                 <svg class="knob-svg" viewBox="0 0 60 60">
                     <circle class="knob-base" cx="30" cy="30" r="25"/>
                     <line class="knob-indicator"