Fix: wrong error message emitted while parsing config

semigodking · Nov 26, 2023 · 11f7304 · 11f7304
1 parent 6bd8a9c
commit 11f7304
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/redsocks.c b/redsocks.c
@@ -242,7 +242,7 @@ static int redsocks_onexit(parser_section *section)
         if (!instance->relay_ss)
             err = "invalid `type` for redsocks";
     }
-    else {
+    else if (!err) {
         err = "no `type` for redsocks";
     }
 

diff --git a/redudp.c b/redudp.c
@@ -549,7 +549,7 @@ static int redudp_onexit(parser_section *section)
             err = "invalid dest address";
     }
 
-    if (instance->config.type) {
+    if (!err && instance->config.type) {
         udprelay_subsys **ss;
         FOREACH(ss, relay_subsystems) {
             if (!strcmp((*ss)->name, instance->config.type)) {
@@ -561,7 +561,7 @@ static int redudp_onexit(parser_section *section)
         if (!instance->relay_ss)
             err = "invalid `type` for redudp";
     }
-    else {
+    else if (!err) {
         err = "no `type` for redudp";
     }