Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing ID types to Byte #18

Merged
merged 1 commit into from
May 14, 2024
Merged

Changing ID types to Byte #18

merged 1 commit into from
May 14, 2024

Conversation

carlosvdr
Copy link
Contributor

issue #17
Based on this recommendations

@carlosvdr carlosvdr self-assigned this May 13, 2024
@carlosvdr carlosvdr linked an issue May 13, 2024 that may be closed by this pull request
Use bytes type for id in GQL schema #17
Closed
@carlosvdr carlosvdr force-pushed the subgraph-enhancement branch 2 times, most recently from d9cabf1 to bb7de3d Compare May 14, 2024 21:41
aasseman
aasseman suggested changes May 14, 2024
View reviewed changes
schema.graphql Outdated Show resolved Hide resolved
@aasseman
Copy link
Contributor

One thing to note is that the IDs built with concat are different than before (breaking change). Though that shouldn't break anything in the TAP software as we don't use those IDs there.

@carlosvdr carlosvdr requested a review from aasseman May 14, 2024 22:32
aasseman
aasseman approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman self-requested a review May 14, 2024 22:39
@aasseman
Copy link
Contributor

You'll need to sign your commits to make the checks happy

@carlosvdr carlosvdr force-pushed the subgraph-enhancement branch from 94e246e to 0b668c4 Compare May 14, 2024 23:09
@carlosvdr carlosvdr merged commit 60d1d61 into main May 14, 2024
1 check passed
@carlosvdr carlosvdr deleted the subgraph-enhancement branch May 14, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use bytes type for id in GQL schema
2 participants
@carlosvdr @aasseman