-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add limit to receipts retrieve #190
Conversation
This comment has been minimized.
This comment has been minimized.
9078cbf
to
d25b615
Compare
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 7022943430
💛 - Coveralls |
d25b615
to
a6289e8
Compare
Rebased onto latest main |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The one change we might consider is to make it possible to know programmatically that the list is incomplete. I'm not what the best approach would be for accomplishing this. I'm setting to approve since the comment makes it very clear how it works.
Helps with keeping the rule of 15,000 max receipts per aggregation request. Also adds a helper function to implement the limit safely. Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
a6289e8
to
0ce2aab
Compare
Rebased onto latest main |
🤖 Cargo Audit Report 🤖 (Empty means OK! 👍) |
Helps with keeping the rule of 15,000 max receipts per aggregation request.
Also adds a helper function to implement the limit safely.
Note about
tap_core/Cargo.toml
:I started getting
Not sure why it even started happening, but the fix was to add the
rt-multi-thread
feature totokio
🤷