-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use typestate for receivedreceipt #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 00:33
0b4a1c7
to
43d615d
Compare
This comment has been minimized.
This comment has been minimized.
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 00:34
43d615d
to
8be0c51
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 7302659958
💛 - Coveralls |
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 00:47
8be0c51
to
ef4e62d
Compare
This comment has been minimized.
This comment has been minimized.
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
2 times, most recently
from
December 19, 2023 01:01
4189a22
to
3d7d588
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 01:11
3d7d588
to
5be9063
Compare
This comment has been minimized.
This comment has been minimized.
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 01:23
5be9063
to
1dcfbff
Compare
This comment has been minimized.
This comment has been minimized.
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
2 times, most recently
from
December 19, 2023 01:36
dc7a3c7
to
674404d
Compare
This comment has been minimized.
This comment has been minimized.
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 01:39
674404d
to
9582606
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 19, 2023 01:40
9582606
to
89b5d94
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aasseman
suggested changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
gusinacio
force-pushed
the
gusinacio/state-machine-refactor
branch
from
December 22, 2023 18:05
bc44a99
to
8616d13
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
🤖 Cargo Audit Report 🤖 (Empty means OK! 👍) |
aasseman
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New state machine
ReceivedReceipt
state machineRemove RAV status
Escrow check is now a state