Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks refactor #207

Merged
merged 32 commits into from
Mar 7, 2024
Merged

Checks refactor #207

merged 32 commits into from
Mar 7, 2024

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Jan 16, 2024 •
edited
Loading

Breaking Change: timestamp check is now the responsibility of the lib user.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
gusinacio added 10 commits March 4, 2024 17:40
@gusinacio
refactor: add check trait
ec5bad8 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: use check trait instead of receipt check enum
0a89801 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove receipt checks adapter
1266c4e 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: fix rebase conflicts
b778f84 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: use check batch inside check trait
5da3e9c 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: use mutable reference for checkingchecks
f7e6c15 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: add rav signature checker
3de3cc7 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
fix: update timestamp check only after rav update
bfb1eb0 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
fix: compile tests
06cf24c 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove unneeded async function
b32d969 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/check-trait-refactor branch from fe1cb3c to 6f5c821 Compare March 4, 2024 20:49
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
gusinacio added 12 commits March 4, 2024 21:09
@gusinacio
test: add sender_id to indexer_mock
a970a4c 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove checks mock adapter, fix warnings, update tests
ab0ddb5 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
fix: missing merge conflicts
8c95954 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
fix: rebase main
0c7bc1c 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
test: add mock checks
e8980e6 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
style: remove unused parameters
3d6ec98 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
style: clippy and fmt
3391b45 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove escrow adapter mock
9aa467a 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove rav storage adapter
0dfbf97 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove receipt storage adapter mock
e782b05 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
refactor: remove auditor executor mock
09a15f1 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
chore: add license
a992181 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/check-trait-refactor branch from 0fa902c to a992181 Compare March 5, 2024 00:09
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
style: fix fmt and clippy
bc86d16 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
test: fix manager and received receipt tests
568144f 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
test: fix unused variables
2eca6a1 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
test: convert checks to mock
f763410 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
test: fix integration tests
9523309 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
test: use static slice for prices
ace9c00 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio marked this pull request as ready for review March 5, 2024 16:56
@gusinacio gusinacio requested a review from aasseman as a code owner March 5, 2024 16:56
@coveralls
Copy link

coveralls commented Mar 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8193880786

Details

  • 305 of 361 (84.49%) changed or added relevant lines in 15 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+6.2%) to 79.986%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/tap_receipt/received_receipt/received_receipt_unit_test.rs 34 35 97.14%
tap_core/src/adapters/mock/executor_mock.rs 74 77 96.1%
tap_core/src/tap_receipt/receipt_auditor.rs 12 15 80.0%
tap_core/src/checks/mod.rs 96 145 66.21%
Files with Coverage Reduction New Missed Lines %
tap_core/src/tap_receipt/receipt_auditor.rs 1 88.1%
tap_core/src/tap_receipt/received_receipt.rs 2 83.8%
tap_core/src/tap_manager/manager.rs 4 86.7%
Totals Coverage Status
Change from base Build 8055723976: 6.2%
Covered Lines: 1123
Relevant Lines: 1404
💛 - Coveralls

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
test: remove unneeded test
e6aec70 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
refactor!: remove timestamp check from manager
0a3b983 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
chore: update futures dependency
797d178 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
chore: remove unused comments
c5b890a 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

aasseman
aasseman suggested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from one Struct name that I find confusing.

Otherwise, I don't remember if you wanted to remove serde from ReceivedReceipts in this PR. Feel free to throw it in here if you'd like 🤷

tap_core/src/checks/mod.rs Show resolved Hide resolved
@gusinacio gusinacio enabled auto-merge March 7, 2024 22:56
aasseman
aasseman approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns will be tackled in next PRs

@gusinacio gusinacio merged commit b577d19 into main Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees

@gusinacio gusinacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gusinacio @coveralls @aasseman