Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub wf on self-hosted runner #163

Merged
merged 50 commits into from
Sep 20, 2024
Merged

GitHub wf on self-hosted runner #163

merged 50 commits into from
Sep 20, 2024

Conversation

fabiocat93
Copy link
Collaborator

No description provided.

@fabiocat93 fabiocat93 self-assigned this Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 45.21385% with 269 lines in your changes missing coverage. Please review.

Project coverage is 67.43%. Comparing base (1de846f) to head (a8aa72b).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/audio/tasks/speaker_embeddings_test.py 36.98% 46 Missing ⚠️
src/tests/audio/tasks/voice_cloning_test.py 37.09% 39 Missing ⚠️
src/tests/audio/tasks/speech_enhancement_test.py 52.23% 32 Missing ⚠️
src/tests/audio/tasks/forced_alignment_test.py 25.00% 30 Missing ⚠️
src/tests/audio/tasks/text_to_speech_test.py 50.81% 30 Missing ⚠️
src/tests/audio/tasks/speech_to_text_test.py 58.33% 20 Missing ⚠️
src/tests/audio/tasks/features_extraction_test.py 36.00% 16 Missing ⚠️
src/tests/audio/tasks/speaker_diarization_test.py 60.00% 14 Missing ⚠️
src/tests/audio/tasks/classification_test.py 25.00% 12 Missing ⚠️
src/tests/text/tasks/embeddings_extraction_test.py 60.00% 10 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   59.33%   67.43%   +8.10%     
==========================================
  Files          83       95      +12     
  Lines        2850     3194     +344     
==========================================
+ Hits         1691     2154     +463     
+ Misses       1159     1040     -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocat93
Copy link
Collaborator Author

Changes:

  • re-organized unit tests adding SKIP based on GPU (cuda) availability
  • integrated self-hosted runner for testing with GPU
  • temporarily removed support for python 3.12 (following harsha's suggestion - apparently there is an existing issue with python 3.12 and pytorch)
  • removed tests on macos with x64 architecture
  • parallelized pytests on multiple cpus
  • removed testmon
  • removed pytest from pre-commit hooks
  • temporarily commented out the transcribe_timestamp workflow because it fail all tests on the GPU (@ibevers can you please double-check that?)
  • fixed an embedding_extraction bug on GPU
  • enabled caching and authentication when checking whether a github exists
  • fixed a plotting bug
  • fixed tutorial naming

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we go ahead and add a 3.11 and 3.12 before merging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added 3.11. would stay like this for now. We can add 3.12 in the future (I want first to check how much money we use with 3.10 and 3.11).

@fabiocat93 fabiocat93 merged commit 1b88936 into main Sep 20, 2024
8 checks passed
@fabiocat93 fabiocat93 changed the title GitHub wf experiments GitHub wf on self-hosted runner Sep 20, 2024
@fabiocat93
Copy link
Collaborator Author

@hvgazula fyi, all set with the self-hosted runner implementation. Thank you again so much for the tutorial and all the brainstorming!!!

@hvgazula
Copy link

btw, what was the solution for the path-related issue you reached out to me about?

@fabiocat93
Copy link
Collaborator Author

btw, what was the solution for the path-related issue you reached out to me about?

inspired by your recommendation, I copied the workspace folder to a different volume and exported a couple of env variables for pytest and poetry

@hvgazula
Copy link

I see. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants