Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

199 task audio io #202

Merged
merged 5 commits into from
Nov 20, 2024
Merged

199 task audio io #202

merged 5 commits into from
Nov 20, 2024

Conversation

fabiocat93
Copy link
Collaborator

@fabiocat93 fabiocat93 commented Nov 19, 2024

Description

This PR adds a utility for saving audio with specified bit depth, encoding, and format. It also introduces functions for parallel processing of audio file reading and writing.

Related Issue(s)

Closes Issue #199

Motivation and Context

These changes address the need for efficient audio file handling and data persistence.

How Has This Been Tested?

  • Unit tests for the new functions
  • Manual verification of file saving and parallel read/write functionality

Types of changes

  • Implemented a function in the Audio class for saving audio to a file
  • Implemented a function for reading multiple audio files in parallel
  • Implemented a function for writing multiple audio files in parallel

Checklist:

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@fabiocat93 fabiocat93 self-assigned this Nov 19, 2024
@fabiocat93 fabiocat93 linked an issue Nov 19, 2024 that may be closed by this pull request
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.58%. Comparing base (113721a) to head (865d2ba).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
src/senselab/audio/data_structures/audio.py 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   60.24%   64.58%   +4.34%     
==========================================
  Files         113      119       +6     
  Lines        4017     4188     +171     
==========================================
+ Hits         2420     2705     +285     
+ Misses       1597     1483     -114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i few suggestions for str and PathLike

src/senselab/audio/tasks/input_output/utils.py Outdated Show resolved Hide resolved
src/tests/audio/tasks/input_output_test.py Outdated Show resolved Hide resolved
src/senselab/audio/tasks/input_output/utils.py Outdated Show resolved Hide resolved
fabiocat93 and others added 3 commits November 20, 2024 02:43
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
@fabiocat93 fabiocat93 merged commit 68dc38d into main Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Audio I/O
3 participants