Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 add speaker diarization #23

Merged
merged 17 commits into from
Jun 1, 2024
Merged

11 add speaker diarization #23

merged 17 commits into from
Jun 1, 2024

Conversation

ibevers
Copy link
Collaborator

@ibevers ibevers commented May 24, 2024

No description provided.

@ibevers ibevers linked an issue May 24, 2024 that may be closed by this pull request
@ibevers ibevers marked this pull request as draft May 24, 2024 22:41
@ibevers ibevers marked this pull request as ready for review May 24, 2024 22:52
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ibevers ! Can you please provide the model name and revision parameters of the methods? In this way, one may call v2.0, v3.0, or v3.1 with the same code, and your script would be more generalizable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, will do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires one more " at the beginning of the file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@fabiocat93
Copy link
Collaborator

hi @ibevers , thank you for your work! please make sure all tests pass

@ibevers
Copy link
Collaborator Author

ibevers commented May 28, 2024

hi @ibevers , thank you for your work! please make sure all tests pass

Will fix this today!

@ibevers ibevers force-pushed the 11-add-speaker-diarization branch 4 times, most recently from 87f4445 to 049213b Compare May 28, 2024 19:06
@ibevers ibevers force-pushed the 11-add-speaker-diarization branch from 049213b to 592bfb4 Compare May 28, 2024 19:07
@ibevers
Copy link
Collaborator Author

ibevers commented May 28, 2024

Fixed! @fabiocat93

@ibevers ibevers force-pushed the 11-add-speaker-diarization branch from f69a014 to e3ac8f6 Compare May 28, 2024 19:57
@ibevers
Copy link
Collaborator Author

ibevers commented May 31, 2024

@fabiocat93 would you mind reviewing this again and merging if everything looks okay?

@fabiocat93
Copy link
Collaborator

@fabiocat93 would you mind reviewing this again and merging if everything looks okay?

hi @ibevers , you should first update it as in the main branch (this is 14 commits behind)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 9.06%. Comparing base (0544636) to head (0936aef).

Files Patch % Lines
...nselab/audio/tasks/pyannote_speaker_diarization.py 0.00% 34 Missing ⚠️
.../audio/tasks/pyannote_speaker_diarization_pydra.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #23       +/-   ##
==========================================
- Coverage   72.97%   9.06%   -63.92%     
==========================================
  Files           4      17       +13     
  Lines          37     298      +261     
==========================================
  Hits           27      27               
- Misses         10     271      +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibevers
Copy link
Collaborator Author

ibevers commented May 31, 2024

Done @fabiocat93

@fabiocat93 fabiocat93 merged commit 43f451c into main Jun 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add speaker diarization
3 participants