-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11 add speaker diarization #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @ibevers ! Can you please provide the model name and revision parameters of the methods? In this way, one may call v2.0, v3.0, or v3.1 with the same code, and your script would be more generalizable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/senselab/cli.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this requires one more " at the beginning of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
hi @ibevers , thank you for your work! please make sure all tests pass |
Will fix this today! |
87f4445
to
049213b
Compare
049213b
to
592bfb4
Compare
Fixed! @fabiocat93 |
f69a014
to
e3ac8f6
Compare
@fabiocat93 would you mind reviewing this again and merging if everything looks okay? |
hi @ibevers , you should first update it as in the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 72.97% 9.06% -63.92%
==========================================
Files 4 17 +13
Lines 37 298 +261
==========================================
Hits 27 27
- Misses 10 271 +261 ☔ View full report in Codecov by Sentry. |
Done @fabiocat93 |
No description provided.