Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Device Truly Available by Creating Trivial Object #234

Conversation

ibevers
Copy link
Collaborator

@ibevers ibevers commented Jan 13, 2025

Description

Related Issue(s)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@ibevers ibevers linked an issue Jan 13, 2025 that may be closed by this pull request
@ibevers ibevers marked this pull request as ready for review January 21, 2025 20:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.39%. Comparing base (113721a) to head (12904d3).
Report is 116 commits behind head on main.

Files with missing lines Patch % Lines
src/senselab/utils/data_structures/device.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   60.24%   65.39%   +5.14%     
==========================================
  Files         113      128      +15     
  Lines        4017     4580     +563     
==========================================
+ Hits         2420     2995     +575     
+ Misses       1597     1585      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocat93 fabiocat93 self-requested a review January 22, 2025 20:39
Copy link
Collaborator

@fabiocat93 fabiocat93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ibevers ! If tests pass, I will approve and merge it later

@fabiocat93 fabiocat93 merged commit 62117c1 into main Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: _select_device_and_dtype does not work on virtualized hardware
3 participants