adding some more API classes (participant, session, dataset) #50
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## audio_abstract_dtype #50 +/- ##
========================================================
+ Coverage 59.12% 61.81% +2.69%
========================================================
Files 36 38 +2
Lines 932 1037 +105
========================================================
+ Hits 551 641 +90
- Misses 381 396 +15 ☔ View full report in Codecov by Sentry. |
scripts/experiment7.py
Outdated
There was a problem hiding this comment.
this pretty easily could've been a test file
There was a problem hiding this comment.
Pretty sure that this in fact did become a test file but probably should limit use of these experiment files to keep the repo clean
There was a problem hiding this comment.
agree. we can remove that scripts folder
| metadata: Dict = Field(default={}) | ||
|
|
||
| @field_validator("id", mode="before") | ||
| def set_id(cls, v: str) -> str: |
There was a problem hiding this comment.
I don't know if this will ever get run because you have a default_factory if the id is not provided so probably not needed.
There was a problem hiding this comment.
But the default_factory is if you use it in a Dataset. Otherwise, you need some checks (and this is why we have the validator)
| return False | ||
|
|
||
|
|
||
| class SenselabDataset(BaseModel): |
There was a problem hiding this comment.
seems like we made complimentary datasets (mine handles Audio/Video, yours has some base functions for the participants and sessions).
There was a problem hiding this comment.
sounds amazing. If you want, we can make a coding session together tomorrow after lunch and marge all what we have
No description provided.