Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibilitiy with PHP 7.4 and add plugin_version to order request #12

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix compatibilitiy with PHP 7.4 and add plugin_version to order request #12

merged 2 commits into from
Mar 6, 2024

Conversation

MarijaIv
Copy link
Collaborator

@MarijaIv MarijaIv commented Mar 6, 2024 •
edited
Loading

What is the goal?

  • Add compatibility with PHP 7.4
  • Add plugin_version field to order request

How is it being implemented?

  • Added one line that was incompatible with PHP 7.4.
  • Added plugin_version field to \Sequra\Core\Model\Api\Builders\CreateOrderRequestBuilder::getPlatform method result.

Does it affect (changes or updates) any sensitive data?

No.

How is it tested?

Manual tests.

How is it going to be deployed?

Standard deployment.

@m1k3lm m1k3lm merged commit 2bc05fd into master Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1k3lm m1k3lm m1k3lm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarijaIv @m1k3lm