B/par 360 fix cors error on assets key validation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
Some merchant can finish teh plugin configuration due to the fact that the assets key validation is failing.
We found out that it was related to the Content-type header used to make the GET request to the
https://${mode}.sequracdn.com/scripts/${merchantId}/${assetsKey}/${methods}_cost.jsonurl.References
How is it being implemented?
Allow the that AjaxServices get method to receive cutomHeaders and send them from the assetsKey validation method
Opportunistic refactorings
Caveats
Does it affect (changes or update) any sensitive data?
No
How is it tested?
Manual tests
How is it going to be deployed?
Standard deployment