Fix the issue with sending statistical data #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1k3lm
requested changes
Oct 10, 2024
| !== strtotime(self::SCHEDULE_TIME)) { | ||
| return []; | ||
| } | ||
| if ($statisticalData->isSendStatisticalData()) { |
There was a problem hiding this comment.
I'd rather return if (!$statisticalData->isSendStatisticalData()) than having nested if
CS-5957
m1k3lm
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
Fix daily report with the statistics is not sent.
References
Issue: LIS-44
How is it being implemented?
Fixed found issues in OrderService and StatisticalDataService.
Does it affect (changes or update) any sensitive data?
No.
How is it tested?
Manual tests.
How is it going to be deployed?
Standard deployment.