This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Add support for builder.AddExpression #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently supported features :
- MinimumLevel.Is() / MinimumLevel.{Level}() / MinimumLevel.Override()
- Enrich.WithProperty()
- Enrich.{ExtensionMethod}()
- WriteTo.{ExtensionMethod}()
- AuditTo.{ExtensionMethod}()
- Filter.{ExtensionMethod}()
Currently suported "parameters" :
- constant expressions
- new Class() where Class inherits/implements an abstract class / interface
- public static property / field to acces an abstract class / interface
Tests :
- expression serilization tests
- sanity checks (AddExpression(exp) behaves the same as applying the expression)
- combination tests (combines different settings sources)
Known advanced missing features as TODOs in ConfigurationExpressionSettingsSerializerTests.cs
tsimbalar
force-pushed
the
addconfigexpression
branch
from
fcc8ba7 to
86caa6e
Compare
tsimbalar
changed the title
|
Ready for review ! 🤓 Thanks ! |
|
Super nice! 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #5 : generate key-value settings from an
Expression<Func<LoggerConfiguration, LoggerConfiguration>>Most of the work is in class
ConfigurationExpressionSettingsSerializer.Currently supported features :
MinimumLevel.Is()/MinimumLevel.{Level}()/MinimumLevel.Override()Enrich.WithProperty()Enrich.{ExtensionMethod}()WriteTo.{ExtensionMethod}()AuditTo.{ExtensionMethod}()Filter.{ExtensionMethod}()Currently supported "parameters" :
new Class()whereClassinherits/implements an abstract class / interfacepublic staticproperty / field to acces an abstract class / interfaceTests :
AddExpression(exp)behaves the same as applying the expression)Known advanced missing features as TODOs in
ConfigurationExpressionSettingsSerializerTests.cs, but they should probably be included in future separate PRs.Note: this PR sits on top of #9 , so I will rebase it properly once #9 has been merged .