merging my code with master #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2020 12:27
ianDesson
requested changes
Mar 8, 2020
|
|
||
| const AdvicePage = () => ( | ||
| <Layout> | ||
| <div id="banner"> | ||
| <h1>FIRST YEAR TIPS</h1> | ||
| </div> | ||
| <div> |
There was a problem hiding this comment.
You can remove this div tag since it doesn't appear to do anything
|
|
||
| const GeneralAdvice = () => { | ||
| return ( | ||
| <Grid container direction="row" justify="space-between" alignItems="center" style={{maxWidth:"90%", margin:"0 auto"}}> |
There was a problem hiding this comment.
Seems that clicking "read more" has the side-effect of causing the whole row to expand to fit the new text. Something that might fix this is either giving the Grid-row a specific height that is greater than the maximum height when the text is expanded. Or, giving each individual "AdviceBox" this height. It seems that the individual one works better on mobile though
| padding: "0 15px 0 15px" | ||
| }}> | ||
| <h3>{props.heading}</h3> | ||
| <p> {isExpanded ? props.expandedBody : props.shortBody} </p> |
There was a problem hiding this comment.
The font is a bit small and hard-to-read try using a font-size of around 1rem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stuff to general advice