fix: Patch preloaded SSL context for requests library #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timo-reymann
force-pushed
the
fix/recursion-error-requests-2-32-up
branch
3 times, most recently
from
ccec733 to
e3d91ee
Compare
timo-reymann
force-pushed
the
fix/recursion-error-requests-2-32-up
branch
4 times, most recently
from
933e452 to
122750f
Compare
stefanor
reviewed
Jan 10, 2025
timo-reymann
force-pushed
the
fix/recursion-error-requests-2-32-up
branch
from
122750f to
4c6f13b
Compare
requests 2.32.0 introduced a preloaded SSL context, which needs to be patched manually unfortunately
timo-reymann
force-pushed
the
fix/recursion-error-requests-2-32-up
branch
from
4c6f13b to
1e18a51
Compare
|
compileall fails now, unrelated to the PR :)
Fixed in d7465d0, pinning the ubuntu runner version |
|
@sethmlarson is there anything blocking this PR from getting merged? :) In case you need anything, please let me know 😊 |
|
As confirmed in #155, this PR doesn't fix that issue so removed the reference. I edited your original comment to get the proper "fixes" linkages too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests 2.32.0 introduced a preloaded SSL context, which needs to be patched manually unfortunately.
This PR adds the according functionality.
Fixes #165
Fixes #143